Fixes for use with mysql #13
Conversation
Mysql require table for getExportedKeys. Otherwice it throws exception Mysql return types in upper case
|
I had exception trying to use with mysql5. Exception was because mysql jdbc driver throw it if table not specified for FK fetching |
|
Also, it would be good to add these type mappings: |
|
Thank you for this PR! Very nice to see it work for MySql. I currently don't have much time, so it may take a while until I get to review. At a quick glance, could you update the readme to include this change and document how to use it with MySql? |
|
Hey. Its my first PR in my life, so I'm not sure how to change readme -
recreate PR, make new one or do something else. Can you explain or tell
where to do this?
But actually usage is the same - just need mysql jdbc url and mysql jdbc
driver in classpath. I dont know what more to notice
Regards,
Victor
…On Fri, Aug 25, 2017 at 11:23 AM, Ólafur Páll Geirsson < ***@***.***> wrote:
Thank you for this PR! Very nice to see it work for MySql. I currently
don't have much time, so it may take a while until I get to review.
At a quick glance, could you update the readme to include this change and
document how to use it with MySql?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB0lMMAZVW1UGpw748N6GmX4f9jPslEjks5sboSDgaJpZM4PB9bg>
.
|
|
@MercurieVV I apologize my slow response!
Congrats!
You can edit readme.md locally, add a new commit and push to your branch. This PR will update.
Perfect. The readme mentions postgres specifically in a few places, it would be nice to mention mysql there too. To make sure that mysql continues to work across future changes, we should probably also run the tests in CI for mysql. The postgresql server is enabled here, I'm sure we can add another line for mysql: Line 4 in d83b224
Go ahead! Please add them, it would be good to test they work as expected. Please let me know if you get stuck, I can try to help out with the tests. |
Mysql require table for getExportedKeys. Otherwice it throws exception
Mysql return types in upper case